code.ossystems Code Review - openembedded-core.git/blob

   1 From 1e91c1d4e37c05cf95058b4b3c3f352d72886f58 Mon Sep 17 00:00:00 2001
   2 From: Hongxu Jia <hongxu.jia@windriver.com>
   3 Date: Tue, 15 Aug 2017 17:31:38 +0800
   4 Subject: [PATCH 7/7] Fix control path where we have str as uninitialized
   5  string
   6
   7 |
   8 /home/ubuntu/work/oe/openembedded-core/build/tmp-musl/work/i586-oe-linux-musl/elfutils/0.164-r0/elfutils-0.164/libcpu/i386_disasm.c:
   9 In function 'i386_disasm':
  10 |
  11 /home/ubuntu/work/oe/openembedded-core/build/tmp-musl/work/i586-oe-linux-musl/elfutils/0.164-r0/elfutils-0.164/libcpu/i386_disasm.c:310:5:
  12 error: 'str' may be used uninitialized in this function
  13 [-Werror=maybe-uninitialized]
  14 |      memcpy (buf + bufcnt, _str, _len);           \
  15 |      ^
  16 |
  17 /home/ubuntu/work/oe/openembedded-core/build/tmp-musl/work/i586-oe-linux-musl/elfutils/0.164-r0/elfutils-0.164/libcpu/i386_disasm.c:709:17:
  18 note: 'str' was declared here
  19 |      const char *str;
  20
  21 Signed-off-by: Khem Raj <raj.khem@gmail.com>
  22 Upstream-Status: Pending
  23
  24 Rebase to 0.170
  25
  26 Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
  27 ---
  28  libcpu/i386_disasm.c | 1 +
  29  1 file changed, 1 insertion(+)
  30
  31 diff --git a/libcpu/i386_disasm.c b/libcpu/i386_disasm.c
  32 index 831afbe..60fd6d4 100644
  33 --- a/libcpu/i386_disasm.c
  34 +++ b/libcpu/i386_disasm.c
  35 @@ -821,6 +821,7 @@ i386_disasm (Ebl *ebl __attribute__((unused)),
  36                             }
  37                           /* Fallthrough */
  38                         default:
  39 +                         str = "";
  40                           assert (! "INVALID not handled");
  41                         }
  42                     }
  43 --
  44 1.8.3.1
  45