code.ossystems Code Review - openembedded-core.git/blob

   1 From 0a78b599b34cc8b5fe6fe82f90e90234e8ab7a56 Mon Sep 17 00:00:00 2001
   2 From: =?UTF-8?q?J=C3=BCrg=20Billeter?= <j@bitron.ch>
   3 Date: Sat, 7 Feb 2015 18:13:21 +0100
   4 Subject: [PATCH] int10: Fix error check for pci_device_map_legacy
   5 MIME-Version: 1.0
   6 Content-Type: text/plain; charset=UTF-8
   7 Content-Transfer-Encoding: 8bit
   8
   9 pci_device_map_legacy returns 0 on success.
  10
  11 Upstream-status: backport 0a78b599b34cc8b5fe6fe82f90e90234e8ab7a56
  12
  13 Signed-off-by: Jürg Billeter <j@bitron.ch>
  14 Reviewed-by: Adam Jackson <ajax@redhat.com>
  15 Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
  16 Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com>
  17 ---
  18  hw/xfree86/int10/generic.c                | 2 +-
  19  hw/xfree86/os-support/linux/int10/linux.c | 2 +-
  20  2 files changed, 2 insertions(+), 2 deletions(-)
  21
  22 diff --git a/hw/xfree86/int10/generic.c b/hw/xfree86/int10/generic.c
  23 index 012d194..8d5c4da 100644
  24 --- a/hw/xfree86/int10/generic.c
  25 +++ b/hw/xfree86/int10/generic.c
  26 @@ -104,7 +104,7 @@ readIntVec(struct pci_device *dev, unsigned char *buf, int len)
  27  {
  28      void *map;
  29
  30 -    if (!pci_device_map_legacy(dev, 0, len, 0, &map))
  31 +    if (pci_device_map_legacy(dev, 0, len, 0, &map))
  32          return FALSE;
  33
  34      memcpy(buf, map, len);
  35 diff --git a/hw/xfree86/os-support/linux/int10/linux.c b/hw/xfree86/os-support/linux/int10/linux.c
  36 index 79b9a88..6ca118f 100644
  37 --- a/hw/xfree86/os-support/linux/int10/linux.c
  38 +++ b/hw/xfree86/os-support/linux/int10/linux.c
  39 @@ -75,7 +75,7 @@ readLegacy(struct pci_device *dev, unsigned char *buf, int base, int len)
  40  {
  41      void *map;
  42
  43 -    if (!pci_device_map_legacy(dev, base, len, 0, &map))
  44 +    if (pci_device_map_legacy(dev, base, len, 0, &map))
  45          return FALSE;
  46
  47      memcpy(buf, map, len);
  48 --
  49 2.1.4
  50