code.ossystems Code Review - openembedded-core.git/blob

   1 From 69b9441eab2a7215509687dc22b48b6f212d22aa Mon Sep 17 00:00:00 2001
   2 From: Rob Bradford <rob@linux.intel.com>
   3 Date: Thu, 4 Jun 2009 15:43:20 +0100
   4 Subject: [PATCH] =?utf-8?q?bgo#584832=20=E2=80=93=20Duplicate=20the=20exec=20string=20returned=20by=20gtk=5Frecent=5Finfo=5Fget=5Fapplication=5Finfo?=
   5 MIME-Version: 1.0
   6 Content-Type: text/plain; charset=utf-8
   7 Content-Transfer-Encoding: 8bit
   8
   9 This function states that the caller is responsible for freeing the string
  10 passed returned by reference. Unfortunately if you do this you get a crash
  11 since the internal value is returned without being duplicated.
  12 ---
  13  gtk/gtkrecentmanager.c |    2 +-
  14  1 files changed, 1 insertions(+), 1 deletions(-)
  15
  16 Upstream-Status: Pending
  17
  18 Index: gtk+-2.21.2/gtk/gtkrecentmanager.c
  19 ===================================================================
  20 --- gtk+-2.21.2.orig/gtk/gtkrecentmanager.c     2010-06-22 18:11:30.000000000 +0800
  21 +++ gtk+-2.21.2/gtk/gtkrecentmanager.c  2010-06-22 18:11:53.000000000 +0800
  22 @@ -1766,7 +1766,7 @@
  23      }
  24
  25    if (app_exec)
  26 -    *app_exec = ai->exec;
  27 +    *app_exec = g_strdup (ai->exec);
  28
  29    if (count)
  30      *count = ai->count;