code.ossystems Code Review - openembedded-core.git/blob

   1 From 64b806ab702a6f445fd84aca5f03bb85b86a66e3 Mon Sep 17 00:00:00 2001
   2 From: Khem Raj <raj.khem@gmail.com>
   3 Date: Thu, 11 Nov 2021 18:37:09 -0800
   4 Subject: [PATCH] framework: do not mix plain and keyword
   5  target_link_libraries() signatures
   6
   7 Fixes
   8 | CMake Error at framework/CMakeLists.txt:461 (target_link_libraries):
   9 |   The plain signature for target_link_libraries has already been used with
  10 |   the target "framework".  All uses of target_link_libraries with a target                                            |   must be either all-keyword or all-plain.
  11 |
  12 |   The uses of the plain signature are here:
  13 |                                                                                                                       |    * framework/CMakeLists.txt:453 (target_link_libraries)
  14 |
  15
  16 Upstream-Status: Submitted [https://github.com/KhronosGroup/Vulkan-Samples/pull/395]
  17
  18 Signed-off-by: Khem Raj <raj.khem@gmail.com>
  19 ---
  20  framework/CMakeLists.txt | 2 +-
  21  1 file changed, 1 insertion(+), 1 deletion(-)
  22
  23 diff --git a/framework/CMakeLists.txt b/framework/CMakeLists.txt
  24 index 948c796..13d3324 100644
  25 --- a/framework/CMakeLists.txt
  26 +++ b/framework/CMakeLists.txt
  27 @@ -450,7 +450,7 @@ target_link_libraries(${PROJECT_NAME} PUBLIC
  28      plugins)
  29
  30  if(${NEED_LINK_ATOMIC})
  31 -    target_link_libraries(${PROJECT_NAME} atomic)
  32 +    target_link_libraries(${PROJECT_NAME} PUBLIC atomic)
  33  endif()
  34
  35  # Link platform specific libraries
  36 --
  37 2.33.1
  38