code.ossystems Code Review - openembedded-core.git/blob

   1 From a309323328d9d6e0bf5d9ea1d75920e53b9beef3 Mon Sep 17 00:00:00 2001
   2 From: Peter Hutterer <peter.hutterer@who-t.net>
   3 Date: Fri, 5 Jan 2018 11:58:42 +1000
   4 Subject: [PATCH] config: fix NULL value detection for ID_INPUT being unset
   5
   6 Erroneous condition caused us to keep going with all devices that didn't have
   7 ID_INPUT set.
   8
   9 Fixes: 5aad81445c8c3d6
  10 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104382
  11 Reviewed-by: Adam Jackson <ajax@redhat.com>
  12 Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
  13
  14 Upstream-status: Backport
  15 https://patchwork.freedesktop.org/patch/196090/
  16 Affects: < 1.20.0
  17 [Yocto # 12899]
  18
  19 Signed-off-by: Armin Kuster <akuser808@gmail.com>
  20
  21 ---
  22  config/udev.c | 2 +-
  23  1 file changed, 1 insertion(+), 1 deletion(-)
  24
  25 diff --git a/config/udev.c b/config/udev.c
  26 index e198e8609..3a73189e2 100644
  27 --- a/config/udev.c
  28 +++ b/config/udev.c
  29 @@ -135,7 +135,7 @@ device_added(struct udev_device *udev_device)
  30  #endif
  31
  32      value = udev_device_get_property_value(udev_device, "ID_INPUT");
  33 -    if (value && !strcmp(value, "0")) {
  34 +    if (!value || !strcmp(value, "0")) {
  35          LogMessageVerb(X_INFO, 10,
  36                         "config/udev: ignoring device %s without "
  37                         "property ID_INPUT set\n", path);
  38 --
  39 2.17.1
  40