code.ossystems Code Review - openembedded-core.git/blob

   1 From 4449246a8d788e71dfe4679fba95955cec5894c1 Mon Sep 17 00:00:00 2001
   2 From: Khem Raj <raj.khem@gmail.com>
   3 Date: Tue, 3 Nov 2020 22:58:26 -0800
   4 Subject: [PATCH] gst_private.h: increse padding in struct _GstClockEntryImpl
   5
   6 When compiling for 32bit architectures with 64bit time_t e.g. riscv32,
   7 the static assert that the GstClockEntryImpl smaller or
   8 equal to the struct _GstClockEntryImpl triggered.
   9 (they were 12bytes off).
  10
  11 To fix this, the padding is increased by 8 bytes (on 32bit).
  12
  13 Upstream-Status: Submitted [https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/694]
  14 Signed-off-by: Khem Raj <raj.khem@gmail.com>
  15 ---
  16  gst/gst_private.h | 2 +-
  17  1 file changed, 1 insertion(+), 1 deletion(-)
  18
  19 diff --git a/gst/gst_private.h b/gst/gst_private.h
  20 index a8897e1..8252ede 100644
  21 --- a/gst/gst_private.h
  22 +++ b/gst/gst_private.h
  23 @@ -522,7 +522,7 @@ struct _GstClockEntryImpl
  24    GstClockEntry entry;
  25    GWeakRef clock;
  26    GDestroyNotify destroy_entry;
  27 -  gpointer padding[19];                 /* padding for allowing e.g. systemclock
  28 +  gpointer padding[21];                 /* padding for allowing e.g. systemclock
  29                                           * to add data in lieu of overridable
  30                                           * virtual functions on the clock */
  31  };
  32 --
  33 2.29.2
  34