1 From 8466fca2a074323a235ef38d425f994a2ff7e64f Mon Sep 17 00:00:00 2001
2 From: Victor Kamensky <kamensky@cisco.com>
3 Date: Mon, 9 Jul 2018 09:31:19 -0700
4 Subject: [PATCH] dwflpp::function_entrypc avoid usage of uninitialized memory
6 Failure on 3.3 release was observed. Failure was elusive and
7 disappeared after seemingly random configure option change, or when
8 code was compiled with -O1 or -O0 (vs default -O2). Running failing
9 test case under valgrind memcheck pointed to couple places where
10 'Conditional jump or move depends on uninitialised value(s)' occured.
12 After addressing these in two places in dwflpp::function_entrypc,
13 valgrind memcheck run is clean and original issue got fixed.
15 Upstream-Status: Backport
16 Signed-off-by: Victor Kamensky <kamensky@cisco.com>
19 1 file changed, 5 insertions(+), 1 deletion(-)
21 diff --git a/dwflpp.cxx b/dwflpp.cxx
22 index bfbb6b096..2172e705a 100644
25 @@ -2465,13 +2465,17 @@ bool
26 dwflpp::function_entrypc (Dwarf_Addr * addr)
30 + // assign default value
33 // PR10574: reject 0, which tends to be eliminated COMDAT
34 if (dwarf_entrypc (function, addr) == 0 && *addr != 0)
37 /* Assume the entry pc is the base address, or (if zero)
38 the first address of the ranges covering this DIE. */
39 - Dwarf_Addr start, end;
40 + Dwarf_Addr start = 0, end;
41 if (dwarf_ranges (function, 0, addr, &start, &end) >= 0)
