code.ossystems Code Review - meta-freescale.git/blob

   1 From cc1f086131aa802abc38428a5a690eb5f35c8225 Mon Sep 17 00:00:00 2001
   2 From: Fabio Estevam <fabio.estevam@freescale.com>
   3 Date: Tue, 18 Feb 2014 23:46:14 -0300
   4 Subject: [PATCH 07/10] pfuze100-regulator: Fix of_node_get() parameter
   5 Organization: O.S. Systems Software LTDA.
   6
   7 Since commit d7857c42 (regulator: pfuze100: Use of_get_child_by_name) we get
   8 the following probe failure:
   9
  10 pfuze100-regulator 1-0008: Full layer: 1, Metal layer: 0
  11 pfuze100-regulator 1-0008: FAB: 0, FIN: 0
  12 pfuze100-regulator 1-0008: regulators node not found
  13 pfuze100-regulator: probe of 1-0008 failed with error -22
  14
  15 Now that of_get_child_by_name() is used we should adjust the device_node pointer
  16 'np' to not get the parent node anymore.
  17
  18 Suggested-by: Shawn Guo <shawn.guo@linaro.org>
  19 Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
  20 Acked-by: Sachin Kamat <sachin.kamat@linaro.org>
  21 Signed-off-by: Mark Brown <broonie@linaro.org>
  22 (cherry picked from commit 0780208ff201feb45e12ebecb39ecac4740b1244)
  23
  24 Upstream-Status: Pending
  25 ---
  26  drivers/regulator/pfuze100-regulator.c | 2 +-
  27  1 file changed, 1 insertion(+), 1 deletion(-)
  28
  29 diff --git a/drivers/regulator/pfuze100-regulator.c b/drivers/regulator/pfuze100-regulator.c
  30 index 15059c74..b9c1b9a 100644
  31 --- a/drivers/regulator/pfuze100-regulator.c
  32 +++ b/drivers/regulator/pfuze100-regulator.c
  33 @@ -295,7 +295,7 @@ static int pfuze_parse_regulators_dt(struct pfuze_chip *chip)
  34         struct device_node *np, *parent;
  35         int ret;
  36
  37 -       np = of_node_get(dev->parent->of_node);
  38 +       np = of_node_get(dev->of_node);
  39         if (!np)
  40                 return 0;
  41
  42 --
  43 2.1.0
  44