]> code.ossystems Code Review - openembedded-core.git/commit
package.bbclass: Do not hide cpio's error
authorRobert Yang <liezhi.yang@windriver.com>
Fri, 14 Dec 2018 06:55:49 +0000 (14:55 +0800)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Fri, 11 Jan 2019 10:38:21 +0000 (10:38 +0000)
commit017a53d2743be2b5d4965a39b4e126fb74f700ad
tree3bd1db7950f1e4d76fd0d2ffa896f8abd74f1745
parentfa95b51b4c867fdb8011881097a0160d7d3e4e71
package.bbclass: Do not hide cpio's error

We use subprocess.check_output() to run the command, which means that we need care
about the error, so the 2>/dev/null should not be used, otherwise it is hard to
debug when the error happens.

I guess it was copied from previous lines, but that command's error can be
ignored (excpet: pass):
   try:
       subprocess.check_output(cmd, shell=True, stderr=subprocess.STDOUT)
   except subprocess.CalledProcessError:
       # Can "fail" if internal headers/transient sources are attempted
       pass

But we don't do this in the current location, so remove "2>/dev/null"

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
meta/classes/package.bbclass