]> code.ossystems Code Review - openembedded-core.git/commit
scripts: Fix return value checks from subprocess.call()'s
authorMikko Rapeli <mikko.rapeli@bmw.de>
Thu, 1 Jun 2017 15:52:59 +0000 (18:52 +0300)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Sat, 3 Jun 2017 22:43:28 +0000 (23:43 +0100)
commit031cf9c7834cd1cba8b03832673a3e3cfcbfae7c
treea6195928b2c6d71cea46163c22fcff8d57b153c4
parente26fa1c34c33ffdc678f8073dade0126aff08b40
scripts: Fix return value checks from subprocess.call()'s

Python function subprocess.call() returns the return value of the
executed process. If return values are not checked, errors may
go unnoticed and bad things can happen.

Change all callers of subprocess.call() which do not check for
the return value to use subprocess.check_call() which raises
CalledProcessError if the subprocess returns with non-zero value.

https://docs.python.org/2/library/subprocess.html#using-the-subprocess-module

All users of the function were found with:

$ git grep "subprocess\.call" | \
  egrep -v 'if.*subprocess\.call|=\ +subprocess\.call|return.*subprocess\.call'

Tested similar patch on top of yocto jethro. Only compile tested
core-image-minimal on poky master branch.

Signed-off-by: Mikko Rapeli <mikko.rapeli@bmw.de>
Signed-off-by: Ross Burton <ross.burton@intel.com>
scripts/runqemu