]> code.ossystems Code Review - openembedded-core.git/commit
cmake: fix typo in toolchain file
authorØystein Walle <ow@datarespons.no>
Tue, 10 Oct 2017 12:59:40 +0000 (14:59 +0200)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Mon, 16 Oct 2017 22:52:03 +0000 (23:52 +0100)
commit03a4dd085e3be2821eff5a1a1e7e96b809465565
tree8c1d10afe2ad0d9a2097205fbbdc00b318b92979
parentcb2c00c369e61b0e61298b0ad076e5bc8bc67bb9
cmake: fix typo in toolchain file

The missing underscore makes CMake define a new variable named "CMAKE"
with the contents "ASM_FLAGS ${CMAKE_C_FLAGS}" instead of a variable
named "CMAKE_ASM_FLAGS" with contents equal to "CMAKE_C_FLAGS". It seems
clear that the intention was to assign "CMAKE_ASM_FLAGS".

CMake uses variables named "CMAKE_<LANG>_FLAGS" for defining default
compiler flags for a given language <LANG>. Leaving this flag unset may
have unintended consequences. Not doing so is however not an error as
far as CMake is concerned so it is silently accepted.

Signed-off-by: Øystein Walle <ow@datarespons.no>
Signed-off-by: Ross Burton <ross.burton@intel.com>
meta/recipes-devtools/cmake/cmake/OEToolchainConfig.cmake