]> code.ossystems Code Review - openembedded-core.git/commit
base.bbclass: avoid 'find -ignore_readdir_race -delete'
authorMatthias Schiffer <matthias.schiffer@ew.tq-group.com>
Tue, 6 Nov 2018 08:56:23 +0000 (09:56 +0100)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Sat, 24 Nov 2018 21:45:48 +0000 (21:45 +0000)
commit0808fe2c1b465114c16265bea3442e878586a8e6
tree2cd038191b8e9c8e63145c1e2de31886b85f7e14
parentf0eebea19ff8d9dfd89d104be04ca3510a546424
base.bbclass: avoid 'find -ignore_readdir_race -delete'

Due to a bug in find [1], -ignore_readdir_race does not work correctly with
-delete. This can lead to spurious build failures when files disappear
while such a command is running; specifically this was seen in the case of
do_configure and do_populate_lic running concurrently for packages
with ${B} == ${WORKDIR}:

   find: '.../sstate-build-populate_lic': No such file or directory

While the issue is fixed in the findutils git master, the find command of
the host system is called here, so we can't ensure that the used version
contains the fix. Many common distros have not updated to a recent enough
findutils version yet (Ubuntu 18.10 contains the fix, while 18.04 is still
affected).

Work around the issue by passing the output of find to 'rm -f' instead of
using -delete.

[1] https://savannah.gnu.org/bugs/?52981

(From OE-Core rev: 8079e2d62e23f7c274f46185e6dad64fa95394c1)

Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Armin Kuster <akuster808@gmail.com>
meta/classes/base.bbclass