]> code.ossystems Code Review - openembedded-core.git/commit
weston: Backport patches to always activate the top-level surface
authorMarek Vasut <marex@denx.de>
Wed, 5 Jan 2022 22:21:41 +0000 (23:21 +0100)
committerSteve Sakoman <steve@sakoman.com>
Thu, 6 Jan 2022 14:27:01 +0000 (04:27 -1000)
commit0a2da895284f1687cf75297fb0f4b20cc9b53489
tree292b10f475e59951133451f6bbd311ef9883ad2b
parent351b02feb9cb680aa3dbe4c8ea4162a6456a469f
weston: Backport patches to always activate the top-level surface

In case the device has only touchscreen input device and no keyboard or mouse,
the top level surface is never activated. The behavior differs from a device
which has a keyboard (or gpio-keys, or even uinput-emulated keyboard), where
callchain activate()->weston_view_activate()->weston_seat_set_keyboard_focus()->
weston_keyboard_set_focus()->wl_signal_emit(&keyboard->focus_signal, keyboard)->
handle_keyboard_focus()->weston_desktop_surface_set_activated(..., true); sets
the top level surface as activated. On device with touchscreen, the above is
never called, hence the top level surface is never activated. Add explicit
weston_desktop_surface_set_activated(shsurf->desktop_surface, true); into
activate() to always active the top level surface.

This fixes at least two known issues on such devices:
- Wayland terminal cursor is an empty bar (full bar with keyboard present)
- Chromium dropdown menus are randomly placed (they are placed correctly
  when keyboard is present, because then chromium can find the activated
  top level surface)

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Steve Sakoman <steve@sakoman.com>
Signed-off-by: Steve Sakoman <steve@sakoman.com>
meta/recipes-graphics/wayland/weston/0002-desktop-shell-Remove-no-op-de-activation-of-the-xdg-.patch [new file with mode: 0644]
meta/recipes-graphics/wayland/weston/0003-desktop-shell-Rename-gain-lose-keyboard-focus-to-act.patch [new file with mode: 0644]
meta/recipes-graphics/wayland/weston/0004-desktop-shell-Embed-keyboard-focus-handle-code-when-.patch [new file with mode: 0644]
meta/recipes-graphics/wayland/weston_8.0.0.bb