]> code.ossystems Code Review - openembedded-core.git/commit
package.py: use subprocess.Popen for rpmdeps call
authorMartin Jansa <martin.jansa@gmail.com>
Sun, 23 Feb 2014 10:44:22 +0000 (11:44 +0100)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Fri, 7 Mar 2014 14:58:40 +0000 (14:58 +0000)
commit148c04c1bf39ca0d21288fdce61c51dc8e1c3226
treeda6cae65a5980983327ca548938ea51636b49d16
parenta4261ab92735abfba835e916931d2e920f335aaa
package.py: use subprocess.Popen for rpmdeps call

* I've noticed errors like this in log.do_package:

  DEBUG: Executing python function package_do_filedeps
  sh: 1: Syntax error: "(" unexpected
  sh: 1: Syntax error: "(" unexpected
  DEBUG: Python function package_do_filedeps finished

  which are actually caused by some filenames included in package
  containing '()' characters

  Maybe we should change meta/classes/package.bbclass to
  fail when some filedeprunner call fails like this and fix
  filedeprunner to escape '()' and other possibly dangerous chars
  it's called like this:
  processed = list(pool.imap(oe.package.filedeprunner, pkglist))

* don't use shell=True
* show the command when it fails and let do_package task to fail

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
meta/lib/oe/package.py