]> code.ossystems Code Review - openembedded-core.git/commit
kernel: fitimage: Repair misuse of shell test command
authorMarek Vasut <marex@denx.de>
Sun, 8 May 2016 11:21:53 +0000 (13:21 +0200)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Fri, 20 May 2016 09:20:21 +0000 (10:20 +0100)
commit158cbd737f9f6c2de756506caf919a0a3d0a05b9
tree0f012e5154ec30fdf31cc9ef39346b61e8bf54cd
parent28777e593d3dd3a5d0ee2effcdca6a971e2887f9
kernel: fitimage: Repair misuse of shell test command

The kernel fitImage must be amended with signature if and only if
UBOOT_SIGN_ENABLE = 1 . In the current case, the UBOOT_SIGN_ENABLE
could be either 0 (default) or 1 , which test -n always correctly
interprets as non-empty string, thus always true. This does not
match the logic above though, so replace the test with check which
passes only for UBOOT_SIGN_ENABLE = 1 .

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Yannick Gicquel <yannick.gicquel@iot.bzh>
Cc: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Ross Burton <ross.burton@intel.com>
meta/classes/kernel-fitimage.bbclass