]> code.ossystems Code Review - openembedded-core.git/commit
epiphany: Do not bypass initialization of variable with __attribute__((cleanup))
authorKhem Raj <raj.khem@gmail.com>
Fri, 10 May 2019 22:26:53 +0000 (15:26 -0700)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Thu, 16 May 2019 08:16:19 +0000 (09:16 +0100)
commit19e4c1f63abc82cf5f8d1eaac28d8fd5d09bf9d3
treef92dee9ec5c961dd5b60f173a5af11abeab7535a
parent44b06d940bc3d623c57df0b06092548912a903c2
epiphany: Do not bypass initialization of variable with __attribute__((cleanup))

This is reported with clang e.g.
../../../../../../../workspace/sources/epiphany/lib/ephy-web-app-utils.c:391:5: error: cannot jump from this goto statement to its label
    goto out;
    ^
../../../../../../../workspace/sources/epiphany/lib/ephy-web-app-utils.c:398:20: note: jump bypasses initialization of variable with __attribute__((cleanup))
  g_autofree char *app_file = g_build_filename (profile_dir, ".app", NULL);
                   ^
../../../../../../../workspace/sources/epiphany/lib/ephy-web-app-utils.c:385:5: error: cannot jump from this goto statement to its label
    goto out;
    ^
../../../../../../../workspace/sources/epiphany/lib/ephy-web-app-utils.c:398:20: note: jump bypasses initialization of variable with __attribute__((cleanup))                                                                                                                     g_autofree char *app_file = g_build_filename (profile_dir, ".app", NULL);
                   ^

Ensure that the initialization is deterministic for goto to work reliably

Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/recipes-gnome/epiphany/epiphany_3.32.1.2.bb
meta/recipes-gnome/epiphany/files/0001-web-app-utils-Clean-up-ephy_web_application_create.patch [new file with mode: 0644]