]> code.ossystems Code Review - openembedded-core.git/commit
initscripts: populate-volatile.sh: run create_file synchronously
authorMatthias Schiffer <matthias.schiffer@ew.tq-group.com>
Wed, 21 Jul 2021 14:10:15 +0000 (16:10 +0200)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Sat, 24 Jul 2021 15:33:42 +0000 (16:33 +0100)
commit1a4ddb0d3f1289e0b67b6eba9be58374d3d7a80b
tree296a554ba0ddddf9cfdd304c67768c00d0a05b16
parent669e74d358db59768862515fe584aa1edf6cec04
initscripts: populate-volatile.sh: run create_file synchronously

The behavior of running create_file in the background was introduced in
d44816bedade ("initscripts: Populate volatile from existing file")
without further explanation. Besides its questionable benefit, this
causes actual issues:

- Not all create_file processes may have finished by the time the
  initscript exits (or when it moves /etc/volatile.cache.build !)
- By making the order of commands nondeterminstic, it could hide
  dependency issues where it was attempted to create files before their
  containing directories

Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/recipes-core/initscripts/initscripts-1.0/populate-volatile.sh