]> code.ossystems Code Review - openembedded-core.git/commit
linux-yocto/4.12: fix aufs compile warning
authorBruce Ashfield <bruce.ashfield@windriver.com>
Tue, 6 Mar 2018 18:11:13 +0000 (13:11 -0500)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Thu, 8 Mar 2018 18:36:16 +0000 (10:36 -0800)
commit1ba624ec410b13da9645efe7bc72908195c08259
tree62005c405e77f3b0865dc9e93c49606917ee1667
parentbde0254a52f0827e15cdc66b91bef7c8ab03ea76
linux-yocto/4.12: fix aufs compile warning

   From: "Kexin(Casey) Chen" <Casey.Chen@windriver.com>

   Forward port linux-yocto-4.8's patch to fix the build warning.

       http://git.yoctoproject.org/cgit/cgit.cgi/linux-yocto-4.8/commit/?h=standard/base&id=7e0dd2f2b0971f0e3191e1ddc088e09eb9855567

   fs/aufs/debug.h:95:19: warning: comparison of constant '0'
   with boolean expression is always false [-Wbool-compare]
      if (unlikely((e) < 0)) \
                    ^

   fs/aufs/vdir.c:852:2: note: in expansion of macro 'AuTraceErr'
      AuTraceErr(!valid);
      ^~~~~~~~~~

   In expansion of AuTraceErr(!valid), comparison of (!valid)
   and constant '0' always passes unlikely(x) false. function
   'static int seek_vdir(struct file *file, struct dir_context *ctx)'
   is to find whether there is a valid vd_deblk following ctx->pos.
   return 1 means valid, 0 for not. Change to AuTraceErr(valid - 1)
   makes more sense.

Signed-off-by: Kexin(Casey) Chen <Casey.Chen@windriver.com>
Signed-off-by: Dengke Du <dengke.du@windriver.com>
Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
meta/recipes-kernel/linux/linux-yocto-rt_4.12.bb
meta/recipes-kernel/linux/linux-yocto-tiny_4.12.bb
meta/recipes-kernel/linux/linux-yocto_4.12.bb