]> code.ossystems Code Review - openembedded-core.git/commit
devicetree.bbclass: Combine stderr into stdout to see actual dtc error
authorJaewon Lee <jaewon.lee@xilinx.com>
Wed, 12 Jun 2019 23:29:01 +0000 (16:29 -0700)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Fri, 14 Jun 2019 21:47:43 +0000 (22:47 +0100)
commit1da43a558ffd5040a1b5aaebfc1c5118f5e59c01
tree512c4a1322649a64478fbba43bc6d00a6a236585
parent144c6c7183dd2b32c65edf325038eb84683a28f8
devicetree.bbclass: Combine stderr into stdout to see actual dtc error

Previously the subprocess command to run dtc was not properly displaying
the error on console. Combining stderr into stdout for the dtc subprocess
so the actual error can be seen on console without having to open the
do_compile log.

For example, previously on a dtc error, just the following stack trace
and dtc command was being shown on console:

File: 'exec_python_func() autogenerated', lineno: 2, function: <module>
     0001:
 *** 0002:devicetree_do_compile(d)
     0003:
File:
function: devicetree_do_compile
     0127:            if not(os.path.isfile(dtspath)) or
not(dts.endswith(".dts") or devicetree_source_is_overlay(dtspath)):
     0128:                continue # skip non-.dts files and non-overlay
files
     0129:        except:
     0130:            continue # skip if can't determine if overlay
 *** 0131:        devicetree_compile(dtspath, includes, d)

    ...

Exception: subprocess.CalledProcessError: Command '['dtc', '-R', '8',
'-b', '0', '-p', '0x1000', '-i', '${INCLUDES}, '-o', 'system-top.dtb',
'-I', 'dts', '-O', 'dtb', 'system-top.dts.pp']' returned non-zero exit
status 1

with this patch, the actual error from the dtc command will be appended
like the following:

Subprocess output:
Error: Label or path not found
FATAL ERROR: Syntax error parsing input tree

Signed-off-by: Jaewon Lee <jaewon.lee@xilinx.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/classes/devicetree.bbclass