]> code.ossystems Code Review - openembedded-core.git/commit
scriptutils: pass in logger as parameter
authorChang Rebecca Swee Fun <rebecca.swee.fun.chang@intel.com>
Wed, 28 Jun 2017 01:59:18 +0000 (09:59 +0800)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Fri, 21 Jul 2017 11:36:36 +0000 (12:36 +0100)
commit21f04b61973dd9029f0e6bff5445e31cd762bf32
tree0db6c84be0fc4e941cf2c0d94a3dbeb44dfd5dea
parentc536ccfd162fc8871838fa229012c562e3f8e0d9
scriptutils: pass in logger as parameter

logger was not defined in scriptutils.py based on the
observation in python traceback.

Traceback (most recent call last):
  File "/workdir/poky/scripts/devtool", line 351, in <module>
    ret = main()
  File "/workdir/poky/scripts/devtool", line 338, in main
    ret = args.func(args, config, basepath, workspace)
  File "/workdir/poky/scripts/lib/devtool/utilcmds.py", line 55, in
edit_recipe
    return scriptutils.run_editor(find_recipe(args, config, basepath,
workspace))
  File "/workdir/poky/scripts/lib/scriptutils.py", line 141, in
run_editor
    logger.error("Execution of '%s' failed: %s" % (editor, exc))
NameError: name 'logger' is not defined

We pass in logger as parameter to run_editor() from where it has
been called (devtool/utilcmds.py and recipetool/newappend.py),
which both modules already has logger setup.

Signed-off-by: Chang Rebecca Swee Fun <rebecca.swee.fun.chang@intel.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
scripts/lib/devtool/utilcmds.py
scripts/lib/recipetool/newappend.py
scripts/lib/scriptutils.py