]> code.ossystems Code Review - openembedded-core.git/commit
kernel.bbclass: fix do_sizecheck() comparison
authorAndrea Adami <andrea.adami@gmail.com>
Sat, 12 Jun 2021 22:14:03 +0000 (00:14 +0200)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Mon, 14 Jun 2021 14:05:08 +0000 (15:05 +0100)
commit254ca956d63b4ce6aa294213b60bb943f9f3a9e6
treedb63f6f3f96f74a40bb410df8ca0aeda5dc4f498
parentee80b59fba4828b88ccf4b8797a4d7816d31a60b
kernel.bbclass: fix do_sizecheck() comparison

The routine do_sizecheck() was historically needed by legacy
devices with limited flash memory.
The lowest extreme is probably with Zaurus collie having exactly
1024*1024 = 1048576 bytes for the kernel partition.

In the years the KERNEL_IMAGE_MAXSIZE has been converted to kilobytes
thus rounded so we have now KERNEL_IMAGE_MAXSIZE_collie = "1024".

The effect is that now the check fails because we hit curiously this
 | WARNING: This kernel zImage (size=1024(K) > 1024(K)) is too big for...
even though zImage is 1047288 bytes (kernel + kexecboot-klibc-initramfs).

Fix this case using test -gt (greater) instead of -ge (greater or equal).

Signed-off-by: Andrea Adami <andrea.adami@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/classes/kernel.bbclass