]> code.ossystems Code Review - openembedded-core.git/commit
glibc: don't ignore global LDFLAGS settings
authorRasmus Villemoes <rasmus.villemoes@prevas.dk>
Mon, 20 Jan 2020 09:23:06 +0000 (09:23 +0000)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Tue, 4 Feb 2020 15:56:24 +0000 (15:56 +0000)
commit4535469d5953b94c9dcad5515be9b807ea7ba621
treebd3603f7b08fb3b771ae81e1f5d2893f2410b1bb
parent6217c3a7201b34888aa2fbae8b6e490bea545574
glibc: don't ignore global LDFLAGS settings

Two things: The -Wl,-rpath-link comment is stale (due to per-recipe
staging), so we no longer need to set our own LDFLAGS to avoid
-Wl,-rpath-link being in there. Second, overriding LDFLAGS should be
done at the recipe level so "bitbake -e" can show what is going on.
Otherwise debugging why one's global LDFLAGS tweaks are being ignored
is needlessly painful.

So pull out the LDFLAGS setting from do_compile, and change it to an
append instead of assignment.

For the benefit of future git blame: the -fuse-ld=bfd setting was
added by ac64c3b96b (glibc: always use bfd linker).

Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/recipes-core/glibc/glibc_2.31.bb