]> code.ossystems Code Review - openembedded-core.git/commit
populate-extfs.sh: error out if debugfs encounters some error
authorChen Qi <Qi.Chen@windriver.com>
Thu, 19 Jun 2014 02:11:33 +0000 (10:11 +0800)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Tue, 24 Jun 2014 09:57:32 +0000 (10:57 +0100)
commit468d3e60ee10348578f78f846e87c02359fdb8bf
tree2b4ce57d5a43b3cbbf11036f4a7f16acdad4b69e
parent8277c71747758e2ba0815a6f5cd11c9e0c9c90ce
populate-extfs.sh: error out if debugfs encounters some error

Previously, even if we encounter some error when populating the
ext filesystem, we don't error out and the rootfs process still
succeeds.

However, what's really expected is that the populate-extfs.sh script
should error out if something wrong happens when using `debugfs' to
generate the ext filesystem. For example, if there's not enough block
in the filesystem, and allocating a block for some file fails, the
failure should not be ignored. Otherwise, we will have a successful
build but a corrupted filesystem.

The debugfs returns 0 as long as the command is valid. That is, even
if the command fails, the debugfs still returns 0. That's really a
pain here. That's why this patch checks the error output to see whether
there's any error logged.

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/populate-extfs.sh