]> code.ossystems Code Review - openembedded-core.git/commit
archiver.bbclass: various fixes for original+diff mode
authorPatrick Ohly <patrick.ohly@intel.com>
Fri, 5 May 2017 10:25:24 +0000 (12:25 +0200)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Sun, 7 Jan 2018 17:06:34 +0000 (17:06 +0000)
commit497795c5a9db8ddb29302780a94eabf6f9b05c9d
tree67c24edbe40dd95e8f0f2ac6fd498b3873d326d5
parent62fbbf99de7b427d95f51d63039ab5a803209904
archiver.bbclass: various fixes for original+diff mode

The diff.gz gets created in do_unpack_and_patch, but
do_deploy_archives did not depend on it, so there was a race
condition. For example, "bitbake linux-intel:do_deploy_archives"
without a prior "bitbake linux-intel:do_kernel_configme" did not
deploy the diff.gz.

When do_unpack_and_patch ran first, it failed because the output
directory didn't exist yet and the error was not detected because the
result of the diff command wasn't checked.

Changing the current working directory in create_diff_gz() without
returning to the original directory caused warnings like this:
   WARNING: linux-intel-... do_unpack_and_patch: Task do_unpack_and_patch changed cwd to .../tmp-glibc/work-shared/intel-corei7-64

(From OE-Core rev: 18aac553ca35049c80b6cc82ff0e69ce8a7a03a9)

(From OE-Core rev: 58ae2be68c2eb4153c09386eebefe9b57400c777)

Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/classes/archiver.bbclass