]> code.ossystems Code Review - openembedded-core.git/commit
utils: Reduce the number of calls to the "dirname" command
authorOleksandr Popovych <opopovyc@cisco.com>
Fri, 20 Aug 2021 12:41:43 +0000 (05:41 -0700)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Sun, 22 Aug 2021 21:21:12 +0000 (22:21 +0100)
commit4b9cf2c80fd14386e0b88a2e6c40a9fa3f1ae0f7
tree57a9bd535a3f237810075978895157fe0ae39287
parent366cf8201e36df1ac836e49de04ccda1f763ca9e
utils: Reduce the number of calls to the "dirname" command

utils.bbclass contains create_cmdline_wrapper() function that
creates wrapper script with additional arguments for any passed
"$cmd" command, and uses several calls to "dirname".

Because "dirname" is an external command, in cases of lots of
calls to wrapped "$cmd", each call of "dirname" will incur
significant overhead.

There are three same calls to "dirname": one for saving it`s
output to "realdir" variable, and other two in "exec" command.
So last two "dirname" calls can be replaced with cached value
from "realdir" variable.

Signed-off-by: Oleksandr Popovych <opopovyc@cisco.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/classes/utils.bbclass