]> code.ossystems Code Review - openembedded-core.git/commit
bbclass: bb.fatal() clean up
authorRobert Yang <liezhi.yang@windriver.com>
Wed, 8 May 2013 09:06:46 +0000 (05:06 -0400)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Wed, 15 May 2013 21:05:07 +0000 (00:05 +0300)
commit4c47525c5a171b1282615c9fbc7d84addef85f92
treea5a28be0e03dce7b0186db77374e008b7aad704a
parentd6fb741dfd828d40317175a624065918b3e5bfec
bbclass: bb.fatal() clean up

The bb.fatal() is defined as:

def fatal(*args):
    logger.critical(''.join(args))
    sys.exit(1)

So anything after bb.fatal() in the same code block doesn't have any
effect, e.g.:

    bb.fatal("%s_%s: %s" % (var, pkg, e))
    raise e

The "raise e" should be removed.

I searched all the files which use bb.fatal(), only the following 3
classes have this issues:

  insane.bbclass
  package.bbclass
  package_rpm.bbclass

[YOCTO #4461]

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
meta/classes/insane.bbclass
meta/classes/package.bbclass
meta/classes/package_rpm.bbclass