]> code.ossystems Code Review - openembedded-core.git/commit
kernel-yocto/kern-tools: fix do_validate_branches clean stage
authorBruce Ashfield <bruce.ashfield@windriver.com>
Sat, 22 Apr 2017 04:36:00 +0000 (00:36 -0400)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Fri, 28 Apr 2017 10:26:05 +0000 (11:26 +0100)
commit4d5890b54cbdac01ee748759578b7b22ed8e61a2
tree9653590a7b334a7c75d3fde01de1a666e7ed634f
parent91faa9132821db4e7010b79943b2cfb804d6f4c5
kernel-yocto/kern-tools: fix do_validate_branches clean stage

It was reported that do_validate_branches was failing with the following
error:

  Log data follows:
  | DEBUG: Executing shell function do_validate_branches
  | HEAD is now at fe0fb8d Merge tag 'v4.10.9' into standard/base
  | mkdir: cannot create directory .: File exists
  |
  | [ERROR] Can't find patch dir at ./patches/standard/base
  | usage: kgit s2q
  | WARNING: exit code 1 from a shell command.
  | ERROR: Function failed: do_validate_branches

This was triggered by the execution of 'kgit-s2q --clean' after forcing
the SRCREV to something other than the tip of the branch. --clean is
being run to remove any sentinel files from previous kernel builds to
ensure that the tree is in a consistent state.

There were two bugs, --clean was being executed and not exiting the
script as it was supposed to. Hence validation for applying patches
was done, and threw the error that eventually makes it to the console.

And the second bug is that since do_validate_branches actually calls
kgit-s2q --clean, the dependency on kern-tools-native needs to be on
that function (versus do_kernel_metadata which runs later).

With the tweaked kern-tool + the dependency fix, we no longer see this
error.

Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/classes/kernel-yocto.bbclass
meta/recipes-kernel/kern-tools/kern-tools-native_git.bb