]> code.ossystems Code Review - openembedded-core.git/commit
send-pull-request: ensure a proper FROM header is included
authorDarren Hart <dvhart@linux.intel.com>
Wed, 26 Jan 2011 17:42:33 +0000 (09:42 -0800)
committerDarren Hart <dvhart@linux.intel.com>
Wed, 26 Jan 2011 17:49:07 +0000 (09:49 -0800)
commit4e23e8f9d0e22cf534c19224cba0be9bedba0120
tree259ce6452271a196ca471a2bd6fc92df8ac7d6c6
parent8ae1f88214acf8f44073f2e499bef59e9433fdfd
send-pull-request: ensure a proper FROM header is included

Commit 94629f2521711055b412f954af19e48b9bda6e50 removes the FROM header when
sending via sendmail to avoid sending mail as the original change committer (as
opposed to the local user). This resulted in mail going out without any FROM
header, which some mailing lists correct by adding the *bounce address as the
FROM.

Correct this by reading FROM from the environment, from a new -f argument, or
from the git user.name and user.email config settings, in that order of
preference. Also display the FROM that will be used prior to the send
confirmation.

This has no effect if the -g (send via git) argument is specified, other than
printing the git sendemail.from config setting.

Signed-off-by: Darren Hart <dvhart@linux.intel.com>
Reported-by: Saul Wold <saul.wold@intel.com>
scripts/send-pull-request