]> code.ossystems Code Review - openembedded-core.git/commit
dropbear: a fix for hang in dropbearkey, built for x32
authorNitin A Kamble <nitin.a.kamble@intel.com>
Thu, 23 May 2013 16:09:20 +0000 (16:09 +0000)
committerPaul Eggleton <paul.eggleton@linux.intel.com>
Fri, 31 May 2013 15:03:25 +0000 (16:03 +0100)
commit4f6d55123fe054e8d081722b91aa12d676b42cb3
treed18220da4e6385ae31a1e9d5352479e00475996c
parentf24b4c3daeba43b352977fcdb807f1ed45c1c694
dropbear: a fix for hang in dropbearkey, built for x32

This commit fixes runtime hang of 'dropbearkey' utility, built for a x32
target abi system. The hang was observed while generating ssh keys, with
this command:
  dropbearkey -t dss -f private

The issue is fixed by changing the code, where 'long' in x86_64 mode is
assumed as 64bit quantity. With the x32 abi, the processor is in x86_64
mode, but the 'long' is a 32bit quantity. Hence the fix uses 'long long'
instead of 'long' to define/access 64bit data variables.

Fixes bug:
[YOCTO #4496]

(From OE-Core master rev: 8f5bc47729edb8cb051d81e9ff1680cb8d2eca25)

Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/recipes-core/dropbear/dropbear-2012.55/0007-dropbear-fix-for-x32-abi.patch [new file with mode: 0644]
meta/recipes-core/dropbear/dropbear.inc