]> code.ossystems Code Review - openembedded-core.git/commit
recipetool: create: fix conflict between SRCREV and tag
authorChang Rebecca Swee Fun <rebecca.swee.fun.chang@intel.com>
Wed, 15 Nov 2017 02:01:13 +0000 (10:01 +0800)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Mon, 18 Dec 2017 18:00:23 +0000 (18:00 +0000)
commit53f8effa3eb07dc7035ff9933e7918318f242579
treec1c0c302cb8676bec08fe90f592ea849ee551390
parent7e924e1607d8aad0f8d48f0be01931c468df2019
recipetool: create: fix conflict between SRCREV and tag

If you specify 'tag=' for a git URL and passed to recipetool create, you
will get into Bitbake expansion error shown below:

----- snip -----
$ devtool add --version 2.4.2 mbedtls "git://github.com/ARMmbed/mbedtls;tag=mbedtls-2.4.2"
...
bb.data_smart.ExpansionError: Failure expanding variable SRCPV, expression was ${@bb.fetch2.get_srcrev(d)} which triggered exception FetchError: Fetcher failure: Conflicting revisions (abeccb9dbd7e19ae91ac50e1edd3803111c5f9b6 from SRCREV and mbedtls-2.4.2 from the url) found, please specify one valid value
----- snip -----

Assuming the tag is valid, we should get the tag commit hash and
drop the usage of 'tag=' from SRC_URI. By using a commit hash
corresponding to the tag will prevent bitbake from accessing
remote repository in order to expand SRCPV.

Signed-off-by: Chang Rebecca Swee Fun <rebecca.swee.fun.chang@intel.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
scripts/lib/recipetool/create.py