]> code.ossystems Code Review - openembedded-core.git/commit
metadata_scm.bbclass: Do not assume ${COREBASE} is a Git repo
authorPeter Kjellerstedt <peter.kjellerstedt@axis.com>
Fri, 29 Apr 2016 17:03:45 +0000 (19:03 +0200)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Wed, 11 May 2016 09:08:30 +0000 (10:08 +0100)
commit53fd0a4a37023642a770a9fbf3cd5511d3c82af7
tree3aa26ce4c52d052d618baa07e88701ae5f61406a
parent29a8c45be2862be02afe2ebbc5c026a42f351990
metadata_scm.bbclass: Do not assume ${COREBASE} is a Git repo

The functions base_detect_revision() and base_detect_branch() try to
extract SCM meta information from the path returned by
base_get_scmbasepath(), which currently returns ${COREBASE}. However,
making the assumption that ${COREBASE} contains SCM meta information
can be false. It is true for Poky, but not necessarily other
environments. A better option is to look for the SCM meta information
based on the meta layer.

Since this works as expected for Git but not SVN, the call to
base_get_metadata_svn_revision() from base_detect_revision() was also
removed. This is not expected to affect anyone (partly based on the
comment in base_get_metadata_svn_revision()).

Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
meta/classes/metadata_scm.bbclass