]> code.ossystems Code Review - openembedded-core.git/commit
sstate: A third fix for for touching files inside pseudo
authorPeter Kjellerstedt <peter.kjellerstedt@axis.com>
Sat, 22 Jan 2022 00:02:51 +0000 (01:02 +0100)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Wed, 26 Jan 2022 06:25:33 +0000 (06:25 +0000)
commit552197a0c4c9f75a9177c00b197ea91296ed9fc4
treeac6eb1b468da3cc0cef02d60ecb47bea9a89038b
parentc134f62062a6359d2d5831ba4cb9694035e4f25a
sstate: A third fix for for touching files inside pseudo

This continues where commit676757f "sstate: fix touching files inside
pseudo" and commit 29fc8599 "sstate: another fix for touching files
inside pseudo" left off.

The previous changes switched from trying to check if the sstate file is
writable before touching it, to always touching the sstate file and
ignoring any errors. However, if the sstate file is actually a symbolic
link that links to nothing, this would actually result in an empty
sstate file being created. And this in turn leads to that future
setscene tasks will fail when they try to unpack the empty file.

Change the code so that if an sstate file linking to nothing already
exists, it is overwritten with the new sstate file. Also change it so
that the temporary file that is used is always removed, even if ln
fails to link the sstate file to it.

Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/classes/sstate.bbclass