]> code.ossystems Code Review - openembedded-core.git/commit
metadata_scm.bbclass: Do not assume ${COREBASE} is a Git repo
authorPeter Kjellerstedt <peter.kjellerstedt@axis.com>
Fri, 29 Apr 2016 17:03:45 +0000 (19:03 +0200)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Wed, 29 Jun 2016 18:34:42 +0000 (19:34 +0100)
commit59b7a5b64c19afc342ca72ccee99cdcfb818e341
treedf0f8ec507670d2a77a78a58c2b8e24a81f7a163
parent2c936f186f3b44e92fb8bd01b0bceb87feec63a4
metadata_scm.bbclass: Do not assume ${COREBASE} is a Git repo

The functions base_detect_revision() and base_detect_branch() try to
extract SCM meta information from the path returned by
base_get_scmbasepath(), which currently returns ${COREBASE}. However,
making the assumption that ${COREBASE} contains SCM meta information
can be false. It is true for Poky, but not necessarily other
environments. A better option is to look for the SCM meta information
based on the meta layer.

Since this works as expected for Git but not SVN, the call to
base_get_metadata_svn_revision() from base_detect_revision() was also
removed. This is not expected to affect anyone (partly based on the
comment in base_get_metadata_svn_revision()).

(From OE-Core rev: 53fd0a4a37023642a770a9fbf3cd5511d3c82af7)

Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Armin Kuster <akuster808@gmail.com>
meta/classes/metadata_scm.bbclass