]> code.ossystems Code Review - openembedded-core.git/commit
ltp: Remove unnecessary check from creat08 and open10
authorHe Zhe <zhe.he@windriver.com>
Tue, 28 Aug 2018 12:43:00 +0000 (20:43 +0800)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Wed, 29 Aug 2018 09:40:08 +0000 (10:40 +0100)
commit5f3ab95b0ed964e08c65ae3159606f27485dbec7
tree2095afbc7b1a117809a24503b8c55e6875f26fa7
parenta5439ff9627d309f6980947f5ee573d85e672228
ltp: Remove unnecessary check from creat08 and open10

Issue: LIN1018-1797

At the point of the following failure, the file being checked, setgid,
is owned by "nobody" in the "nogroup" and tries to inherit SGID from
its parent directory who is in group of "bin". This is forbidden since
Linux kernel v4.18-rc4, unless current process is given CAP_FSETID
beforehand. See "Fix up non-directory creation in SGID directories" in
the kernel. The check in Block3 succeeds since it becomes root again
then.

creat08 3 TFAIL : creat08.c:368: testdir.B.1026/setgid: Incorrect modes, setgid bit should be set
creat08 4 TFAIL : creat08.c:376: Test failed in block2.

open10 3 TFAIL : open10.c:352: open10.testdir.B.1045/setgid: Incorrect modes, setgid bit not set
open10 4 TFAIL : open10.c:359: Test failed in block2.
open10 6 TFAIL : open10.c:443: Test failed because of above failures.

Backport a patch from upstream.

Signed-off-by: He Zhe <zhe.he@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/recipes-extended/ltp/ltp/0043-open-creat-skip-S_ISGID-check-on-files-created-by-no.patch [new file with mode: 0644]
meta/recipes-extended/ltp/ltp_20180515.bb