]> code.ossystems Code Review - openembedded-core.git/commit
archiver.bbclass: enhance do_ar_recipe task signature
authorPatrick Ohly <patrick.ohly@intel.com>
Thu, 4 May 2017 14:42:41 +0000 (16:42 +0200)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Sun, 7 Jan 2018 17:06:34 +0000 (17:06 +0000)
commit62fbbf99de7b427d95f51d63039ab5a803209904
treeeac60056d67bba35816e96b9c97d9a9500a99bcb
parented2d0781d3e991a7e0eb4bf7a04a9e91cd8793be
archiver.bbclass: enhance do_ar_recipe task signature

Previously, do_ar_recipe ran again unnecessarily when adding or
removing classes like buildhistory.bbclass, because that changes the
BBINCLUDED variable which do_ar_recipe uses to find .bbappend files.

This is both extra work and also sometimes triggered "basehash
changed" errors (seen under oe-selftest, which adds machine.inc and
bblayers.inc) because BBINCLUDED is special and does not cause
the basehash to be recalculated.

The file *content* already was not considered in the task signature,
instead relying indirectly on PF (which includes the revision assigned
by a PR server) to ensure that a new versioned source archive gets
created each time there is a rebuild.

Therefore it makes sense to use the same mechanism and also ignore the
file *list*, i.e. exclude BBINCLUDED from the task signature.

(From OE-Core rev: 9666f0e0b02efc14226c77497fd38f79fc372f98)

(From OE-Core rev: f560bfe15d283c59094a0f7987fad10baad053b4)

Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/classes/archiver.bbclass