]> code.ossystems Code Review - openembedded-core.git/commit
recipetool: Fix circular reference in SRC_URI
authorSaul Wold <Saul.Wold@windriver.com>
Thu, 3 Feb 2022 19:43:48 +0000 (11:43 -0800)
committerSteve Sakoman <steve@sakoman.com>
Sat, 19 Feb 2022 19:59:34 +0000 (09:59 -1000)
commit64434ffd6d406e4c3d1e9ca2fb72fa97990346d8
tree2edf32773e33c434b5b806eed9bd884ecbe0ff1e
parentee05539fc6fadff7f14c8609641021fc497cbd8e
recipetool: Fix circular reference in SRC_URI

When creating a new recipe.bb file for a binary, don't use BP which
includes the version information, instead use BPN which is just the
name base Package Name.

Since PB is not specified, it takes the default:
PV = "1.0+git${SRCPV}"

But SRCPV is defined in terms of the SRC_URI, which leads to infinite
recursion (traceback below). Here are the pertinent variables which
cause the recursion:

SRC_URI = "git://github.com/lvc/abi-dumper;protocol=https;subdir=${BP}"
BP = "${BPN}-${PV}"
PV = "1.0+git${SRCPV}"
SRCPV = "${@bb.fetch2.get_srcrev(d)}"

def get_srcrev(d, method_name='sortable_revision'):
    # ... trimmed
    scms = []
    fetcher = Fetch(d.getVar('SRC_URI').split(), d)
    # ... trimmed

[YOCTO #14040]

Signed-off-by: Saul Wold <saul.wold@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
(cherry picked from commit 3b8d43fc53ee13d39abc3b2a1f706a97fcf752aa)
Signed-off-by: Steve Sakoman <steve@sakoman.com>
scripts/lib/recipetool/create.py