]> code.ossystems Code Review - openembedded-core.git/commit
kernel.bbclass: Fix do_sizecheck behaviour
authorMike Crowe <mac@mcrowe.com>
Fri, 8 Dec 2017 13:43:26 +0000 (13:43 +0000)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Sat, 6 Jan 2018 10:11:42 +0000 (10:11 +0000)
commit6476d2c0ede654dca51a81045a8ccbca532c317d
tree8140efe78e8febededb494e2587952a2d3315bc5
parent8eb20c43232ae87c65d27810e5250676bb1d9675
kernel.bbclass: Fix do_sizecheck behaviour

During the introduction of support for multiple kernel image types in
849b67b2e4820564b5e5c9bd4bb293c44351c5f3, do_sizecheck was changed to only
warn if any kernel was bigger than ${KERNEL_IMAGE_MAXSIZE}. (Well, it tried
to warn - it turns out that there's no function called "warn", it should be
"bbwarn".) The previous behaviour had been to fail the build if the single
kernel image did not fit.

It seems possible that people might be generating both compressed and
uncompressed kernels and only really care whether the compressed one fits.
This means that we shouldn't just always fail if any of the images are too
large. So, let's warn (correctly this time) on every image that is too
large, but only ultimately fail if no image will fit. The build will also
fail if ${KERNEL_IMAGETYPES} is empty, but I hope that no-one needs to do
that.

While we're here correct a typo in the KERNEL_IMAGE_MAXSIZE validity check.

Signed-off-by: Mike Crowe <mac@mcrowe.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
(cherry picked from commit 59f1ee104d1a6c04b0690b7c8ce481449da174d6)
Signed-off-by: Armin Kuster <akuster808@gmail.com>
meta/classes/kernel.bbclass