]> code.ossystems Code Review - openembedded-core.git/commit
oe-selftest: devtool: fix test_devtool_add hanging on some machines
authorPaul Eggleton <paul.eggleton@linux.intel.com>
Wed, 13 Sep 2017 20:57:44 +0000 (08:57 +1200)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Wed, 13 Sep 2017 20:59:48 +0000 (21:59 +0100)
commit6a7c50def569b5e86aa17bd9b287e8c63781dcb0
tree185e6fcb5b232ca6902e3a497836995be285af3a
parentde70799af1a8bfe2fac22b90401053275d4714ba
oe-selftest: devtool: fix test_devtool_add hanging on some machines

The code in scriptutils which implements the logic for running the
editor used by devtool edit-recipe looks at the VISUAL environment
variable before EDITOR, and thus if VISUAL is set in the environment it
will override the EDITOR value we are setting here, the editor (usually
vim) launches and there's nothing to stop it running forever short of
manually killing it. Set VISUAL instead to fix this.

Apparently VISUAL is in fact the variable we should really be preferring
here - I don't think I knew that but somehow I got it right in the code,
just not in the test. Here are the details for the curious:

  https://unix.stackexchange.com/questions/4859/visual-vs-editor-whats-the-difference

Fixes [YOCTO #12074].

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/lib/oeqa/selftest/cases/devtool.py