]> code.ossystems Code Review - openembedded-core.git/commit
buildhistory.bbclass: avoid exception for empty BUILDHISTORY_FEATURES variable
authorPeter Bergin <peter@berginkonsult.se>
Fri, 29 Jan 2021 09:50:54 +0000 (10:50 +0100)
committerSteve Sakoman <steve@sakoman.com>
Thu, 4 Feb 2021 14:57:53 +0000 (04:57 -1000)
commit6b5ff13fcbcfe980b50893a8bfe86ebf7a4ef3bf
tree844199ac8623f13c99bd818018fc5beb241faa6e
parent4d70a149cee6c4fb3a74514ef6041aaa068cc293
buildhistory.bbclass: avoid exception for empty BUILDHISTORY_FEATURES variable

An exception is fired when a BuildStarted event is sent to buildhistory bbclass
and the variable BUILDHISTORY_FEATURES is not set.

    ERROR: Execution of event handler 'buildhistory_eventhandler' failed
    Traceback (most recent call last):
      File "<...>/meta/classes/buildhistory.bbclass", line 862, in buildhistory_eventhandler(e=<bb.event.BuildStarted object at 0x7f94c3810250>):
         python buildhistory_eventhandler() {
        >    if e.data.getVar('BUILDHISTORY_FEATURES').strip():
                 reset = e.data.getVar("BUILDHISTORY_RESET")
    AttributeError: 'NoneType' object has no attribute 'strip'

This can happen in a multiconfig build where the default configuration use the
buildhistory class but not the configuration in mc. It should be a rare case that
this happens and it was found in a missconfigured build.

Signed-off-by: Peter Bergin <peter@berginkonsult.se>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
(cherry picked from commit a74e30a4de02c8efd3e7102ba7a4fe06df53cc34)
Signed-off-by: Steve Sakoman <steve@sakoman.com>
meta/classes/buildhistory.bbclass