]> code.ossystems Code Review - openembedded-core.git/commit
powertop: fix segfault in dump mode
authorDexuan Cui <dexuan.cui@intel.com>
Fri, 27 Aug 2010 13:02:34 +0000 (21:02 +0800)
committerRichard Purdie <rpurdie@linux.intel.com>
Thu, 2 Sep 2010 08:50:48 +0000 (09:50 +0100)
commit6c098ebe424c4cdc39a93b4e50ff59b4b7894c98
tree6c5290392008393b9248713034878e05f2fd2b4a
parentf2011318ece69ab27bad24f474d54422709bdc8f
powertop: fix segfault in dump mode

The cause is: in dump mode, setup_windows() is not invoked so the
*_window variables, like cstate_window, are still NULL; later in
main() -> show_cstates(), the functions, like wrefresh(), will trigger
segfault.

After discussing in PowerTop mailling list, I think the right solution is
we should stub out the ncurses calls in dump mode.

(The patch was also sent to upstream PowerTop mailling list.)

This fixes [BUGID #195]:
Bug 195 - [sdk] powertop segfault when running with dump option

Signed-off-by: Dexuan Cui <dexuan.cui@intel.com>
meta/recipes-kernel/powertop/powertop-1.13/stub_out_the_ncurses_calls_in_dump_mode.patch [new file with mode: 0644]
meta/recipes-kernel/powertop/powertop_1.13.bb