]> code.ossystems Code Review - openembedded-core.git/commit
kernel, license, sstate, rootfs.py: Remove deploy directory README
authorMike Crowe <mac@mcrowe.com>
Tue, 14 Feb 2017 14:20:02 +0000 (14:20 +0000)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Tue, 28 Feb 2017 11:26:33 +0000 (11:26 +0000)
commit71e9e88847d7000781642ea6187ebd8f40dfdcfe
tree8eaddd81a3f0986b80920e27a2872a93584249cb
parentea296ab42a7a65055657b950d8248d94f0ac56f1
kernel, license, sstate, rootfs.py: Remove deploy directory README

It isn't clear that the README_-_DO_NOT_DELETE_FILES_IN_THIS_DIRECTORY.txt
file in the deploy directory warrants the complexity it brings elsewhere.
Let's just remove it entirely.

In particular, if two do_image_complete tasks run in parallel they risk
both trying to put their image into ${DEPLOY_DIR_IMAGE} at the same time.
Both will contain a README_-_DO_NOT_DELETE_FILES_IN_THIS_DIRECTORY.txt
file. In theory this should be safe because "cp -alf" will just cause one
to overwrite the other. Unfortunately, coreutils cp also has a race[1]
which means that if one copy creates the file at just the wrong point the
other will fail with:

 cp: cannot create hard link ‘..../tmp-glibc/deploy/images/pantera/README_-_DO_NOT_DELETE_FILES_IN_THIS_D.txt’ to
+‘..../tmp-glibc/work/rage_against-oe-linux-gnueabi/my-own-image/1.0-r0/deploy-my-own-image-complete/README_-_DO_NOT_DELETE_FILES_IN_THIS_DIRECTORY.txt’: File exists

[1] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=25680

Signed-off-by: Mike Crowe <mac@mcrowe.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
meta/classes/kernel.bbclass
meta/classes/license.bbclass
meta/classes/sstate.bbclass
meta/files/deploydir_readme.txt [deleted file]
meta/lib/oe/rootfs.py