]> code.ossystems Code Review - openembedded-core.git/commit
image-live.bbclass: order do_bootimg after do_rootfs
authorGuillaume Champagne <champagne.guillaume.c@gmail.com>
Wed, 26 May 2021 18:32:50 +0000 (14:32 -0400)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Thu, 27 May 2021 12:20:44 +0000 (13:20 +0100)
commit73c21db8e54002b300ba4972cb49c0577acc5406
tree50190484a9facffb029b98c81356e879e339cf2f
parent2c70334f847ecb872b3cf1061b3a8ed86557fddb
image-live.bbclass: order do_bootimg after do_rootfs

do_bootimg expects IMGDEPLOYDIR to exist, since it stores its artifacts
there. Therefore, do_bootimg should run after do_rootfs because
IMGDEPLOYDIR is created before do_rootfs runs since IMGDEPLOYDIR is
contained in do_rootfs' [cleandirs] varflag.

When do_bootimg depends on ${PN}:do_image_${LIVE_ROOTFS_TYPE},
do_bootimg is correctly ordered after do_rootfs because
do_image_${FSTYPE} tasks are added after do_image and do_image itself is
added after do_rootfs.

However, when do_bootimg doesn't depend on
${PN}:do_image_${LIVE_ROOTFS_TYPE}
(introduced by: 96f47c39f1d17f073243913d524bde84add41d8f), do_bootimg
can run before do_rootfs, thus before IMGDEPLOYDIR is created. To
avoid this situation, do_bootimg is now explicitly ordered after
do_rootfs.

Signed-off-by: Guillaume Champagne <champagne.guillaume.c@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/classes/image-live.bbclass