]> code.ossystems Code Review - openembedded-core.git/commit
directfb: don't patch pkg-config files
authorAndré Draszik <andre.draszik@linaro.org>
Fri, 19 Jul 2013 08:39:10 +0000 (09:39 +0100)
committerSaul Wold <sgw@linux.intel.com>
Mon, 22 Jul 2013 16:44:10 +0000 (09:44 -0700)
commit795db65706d28bc194244a2ebbe6624ded584a33
treeeab2c19c9592fff16a6291ba762fcef044cbef0a
parenta768047cb8fc00ecf13f4db08117c348a9312c47
directfb: don't patch pkg-config files

We are currently getting build failures of projects that rely on
being able to access DirectFB's internal include directories, as
returned via pkg-config, since the include paths returned by
pkg-config are incomplete.

The reason for that is the patch that is being removed with this
change. It modified the cflags returned by pkg-config in an
incorrect way, causing us to miss important include paths:

For reference, pkg-config output with incorrect patch applied:
  ad@bril0118 #513 ~> pkg-config --cflags directfb-internal
-D_GNU_SOURCE -D_REENTRANT -I<builddir>/tmp/sysroots/<machine>/usr/include/directfb -I<builddir>/tmp/sysroots/<machine>/usr/include

Now, with the incorrect patch removed, the output is as expected:
  ad@bril0118 #514 ~> pkg-config --cflags directfb-internal
-D_GNU_SOURCE -D_REENTRANT -I<builddir>/tmp/sysroots/<machine>/usr/include/directfb-internal -I<builddir>/tmp/sysroots/<machine>/usr/include/directfb

Overall, the removed patch is not needed - pkg-config does the right
thing these days and we can simply use the correctly working upstream
versions of all DirectFB .pc files.

Signed-off-by: André Draszik <andre.draszik@linaro.org>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
meta/recipes-graphics/directfb/directfb.inc
meta/recipes-graphics/directfb/directfb/directfb-1.2.x-fix-pkgconfig-cflags.patch [deleted file]