]> code.ossystems Code Review - openembedded-core.git/commit
insane/package: Fix cases where QA errors aren't fatal
authorRichard Purdie <richard.purdie@linuxfoundation.org>
Tue, 12 Jan 2016 18:00:13 +0000 (18:00 +0000)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Wed, 13 Jan 2016 00:09:00 +0000 (00:09 +0000)
commit7e36d13212763fe409747aba011c020c9aeba6d7
treefa02ac31e1db728a6608dca5e987c9f13e2d0f58
parent2306683634435b990e63020fc5cf91753bbaf7b6
insane/package: Fix cases where QA errors aren't fatal

When using package_qa_handle_error(), we need to check QA_SANE and
give a fatal error if issues were raised. The main insane checks do
this, the anonymous python in insane does not, nor does the code in
package.bbclass. This was likely missed when the function was
introduced to package.bbclass.

The impact is that errors can be shown but don't stop the build
(do_package succeeds), the initial build fails due to the errors
shown but subsequent builds succeed. This is clearly broken.

The solution is to check QA_SANE in places we use the handle_error
function.

[YOCTO #8907]

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/classes/insane.bbclass
meta/classes/package.bbclass