]> code.ossystems Code Review - openembedded-core.git/commit
prelink: Fix Segmentation fault error when prelink qemu
authorRobert Yang <liezhi.yang@windriver.com>
Thu, 11 Oct 2018 04:06:53 +0000 (12:06 +0800)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Fri, 12 Oct 2018 07:44:05 +0000 (08:44 +0100)
commit7f5d6f6b70cb1eb486d3ff5c029fc3c6202fc826
treec00d383606f444f2da23c61a5a8b33bf7d0c5173
parent7257f209e317db62f92279fc2ff7d6d1e5eddf75
prelink: Fix Segmentation fault error when prelink qemu

The info->resolvetls might be NULL according to src/prelink.c:
[snip]
 /* Dynamic linker does not depend on any other library,
    all symbols resolve to themselves with the exception
    of SHN_UNDEF symbols which resolve to 0.  */
if (info->symtab[r_sym].st_shndx == SHN_UNDEF)
  {
    info->resolveent = NULL;
    info->resolvetls = NULL;
[snip]

So we must check it before use its members, otherwise, there might be
Segmentation fault error.

Fixed:
MACHINE = "qemumips"
IMAGE_INSTALL_append = " qemu"
$ bitbake core-image-minimal
[snip]
| /path/to/qemumips-poky-linux/core-image-minimal/1.0-r0/temp/run.prelink_image.1000: line 111:  1010 Segmentation fault      (core dumped)
[snip]

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/recipes-devtools/prelink/prelink/0001-src-arch-mips.c-check-info-resolvetls-before-use-its.patch [new file with mode: 0644]
meta/recipes-devtools/prelink/prelink_git.bb