]> code.ossystems Code Review - openembedded-core.git/commit
update-alternatives: convert file renames to PACKAGE_PREPROCESS_FUNCS
authorAndré Draszik <andre.draszik@jci.com>
Wed, 16 Jan 2019 12:51:15 +0000 (12:51 +0000)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Fri, 1 Feb 2019 07:31:46 +0000 (07:31 +0000)
commit8c3db2fa735e5933f842f80321bb3ed38753812d
tree88faa2691cd42f73f56f748416228a21c328191d
parent577a3723052c4465a7858cd2de05292e67a93cce
update-alternatives: convert file renames to PACKAGE_PREPROCESS_FUNCS

At the moment, the update-alternatives file renaming is
happening right after copying into PKGD during packaging
time using an _append OVERRIDE to the copy function
perform_packagecopy().

This is not really readable and hard to maintain.

Additionally, this makes it impossible to e.g. populate
PACKAGES dynamically using do_split_packages() and still
do update-alternatives - update-alternatives file renaming
requires the PACKAGES variable to have been fully populated
to work correctly. On the other hand, do_split_packages()
can only execute after perform_packagecopy(), as it needs
PKGD populated; so it's impossible to insert
do_split_packages() early enough in a deterministic way in
this use-case.

As there doesn't seem to be a reason not to, convert
this to a proper function and use PACKAGE_PREPROCESS_FUNCS
instead - after all, that's what this is meant for.

No other classes or recipes in oe-core or meta-openembededd
seem to have a hard requirement on update-alterantives
executing before any other PACKAGE_PREPROCESS_FUNCS, so
this should be perfectly fine.

The only implication is that if compress_doc is inherited,
compressed man-page file names will end up being, e.g.
    eject.1.util-linux.gz
  or
    eject.1.gz.util-linux
based on the include of compress_doc.bbclass vs.
update-alternatives.bbclass order, but the symlink created
(alternative name) will always be correct.

This solves both problems:
* the code is easier to read / follow
* the above described use-case can be accomodated easily

[YOCTO #13058]

Signed-off-by: André Draszik <andre.draszik@jci.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/classes/update-alternatives.bbclass