]> code.ossystems Code Review - openembedded-core.git/commit
utils: Reduce the number of calls to the "dirname" command
authorOleksandr Popovych <opopovyc@cisco.com>
Fri, 20 Aug 2021 12:41:43 +0000 (05:41 -0700)
committerSteve Sakoman <steve@sakoman.com>
Fri, 27 Aug 2021 14:58:08 +0000 (04:58 -1000)
commit912c9eda653c45fee2f55092fbe281efba897bc0
tree4319507169752b55f78151924cb90db06d0659b3
parent69e33b9eee6ae97208e766fd96353dfcb8c20bd5
utils: Reduce the number of calls to the "dirname" command

utils.bbclass contains create_cmdline_wrapper() function that
creates wrapper script with additional arguments for any passed
"$cmd" command, and uses several calls to "dirname".

Because "dirname" is an external command, in cases of lots of
calls to wrapped "$cmd", each call of "dirname" will incur
significant overhead.

There are three same calls to "dirname": one for saving it`s
output to "realdir" variable, and other two in "exec" command.
So last two "dirname" calls can be replaced with cached value
from "realdir" variable.

Signed-off-by: Oleksandr Popovych <opopovyc@cisco.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
(cherry picked from commit 4b9cf2c80fd14386e0b88a2e6c40a9fa3f1ae0f7)
Signed-off-by: Steve Sakoman <steve@sakoman.com>
meta/classes/utils.bbclass