]> code.ossystems Code Review - openembedded-core.git/commit
scripts/runqemu: Fix logic error causing failures with MACHINE from the environment
authorRichard Purdie <richard.purdie@linuxfoundation.org>
Wed, 28 Nov 2018 16:09:56 +0000 (16:09 +0000)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Sat, 1 Dec 2018 11:37:49 +0000 (11:37 +0000)
commit98d113ae52cbbc88773a81a17b0933412a8e463b
treea82d4f0ca6add387c26489a709fdf58cfc192446
parent532984708436bdfa3a8cac2c684a425eb249bad0
scripts/runqemu: Fix logic error causing failures with MACHINE from the environment

MACHINE=qemux86-64 oe-selftest -r runqemu.RunqemuTests.test_boot_machine_slirp_qcow2

fails yet

oe-selftest -r runqemu.RunqemuTests.test_boot_machine_slirp_qcow2

with MACHINE in local.conf would work.

It turns out that:

runqemu slirp wic.qcow2 qemux86-64

works but:

MACHINE=qemux86-64 runqemu slirp wic.qcow2 qemux86-64

does not.

The reason are the misplaced return statements in runqemu, its skipping a block
of logic when MACHINE is set in the environment when it shouldn't. Fix this.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
scripts/runqemu