]> code.ossystems Code Review - openembedded-core.git/commit
insane.bbclass: fix false negative in build-deps QA check
authorPatrick Ohly <patrick.ohly@intel.com>
Mon, 15 Jun 2015 16:05:13 +0000 (18:05 +0200)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Tue, 23 Jun 2015 10:38:12 +0000 (11:38 +0100)
commit9f5792088315ab42f77fe1a1af7d2225e7ad5418
treec9cffad43880649e1cc566142826eafc3419a948
parent04066239e9cd6a8461fb2c18e826289469ac1240
insane.bbclass: fix false negative in build-deps QA check

When a recipe called 'foobar-test' links against 'foobar' without
listing that in DEPENDS, the build-deps check misses that error
because it looks for 'foobar' in a package string containing (among
others) the 'foobar-test' name, leading to the incorrect conclusion
that the package is listed as dependency.

The 'packages' string needs to be split into individual package names
before the check. Doing that once directly after reading the value is
more efficient than splitting inside package_qa_check_rdepends() because
the caller also needs the individual components.

Also use a set to speed up the 'package in packages' check.

Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
meta/classes/insane.bbclass