]> code.ossystems Code Review - openembedded-core.git/commit
uboot-sign: Fix build when UBOOT_DTB_BINARY is empty
authorAlex Kiernan <alex.kiernan@gmail.com>
Wed, 17 Apr 2019 18:31:16 +0000 (18:31 +0000)
committerArmin Kuster <akuster808@gmail.com>
Sat, 11 May 2019 14:45:49 +0000 (07:45 -0700)
commita0ecd3b56b86fa47ae0b051548bdf6cb08fc2d98
tree0e4ab508217bdbf59c731910d88ef1d5408788c0
parentda6806df8bb3994e80d8deb6edb406dba92249e0
uboot-sign: Fix build when UBOOT_DTB_BINARY is empty

When UBOOT_DTB_BINARY is empty and because the code now changes
directory into ${B}, the test for the existence becomes `[ -f ]` which
succeeds and subsequently the install fails.

Reorder the code so it's clear that UBOOT_DTB_BINARY empty is an
expected configuration and then quote UBOOT_DTB_BINARY everywhere so
no one trips over this again.

Fixes: bacb59079eb6 ("uboot-sign: add support for different u-boot configurations")
Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Armin Kuster <akuster808@gmail.com>
meta/classes/uboot-sign.bbclass